Add more Rustified version of kernel_check #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squell
force-pushed
the
update-kernel-check
branch
2 times, most recently
from
493c574
to
3fe10bd
Compare
squell
force-pushed
the
update-kernel-check
branch
from
3fe10bd
to
081ea55
Compare
squell
force-pushed
the
update-kernel-check
branch
from
081ea55
to
5bffcf4
Compare
bjorn3
reviewed
Oct 23, 2024
|
|
||
| #[cfg(not(target_os = "linux"))] | ||
| pub fn kernel_check(target_major: u32, target_minor: u32) -> Result<(), Error> { | ||
| // if someone managed to compile this on anything else than Linux: your luck runs out here |
There was a problem hiding this comment.
Maybe have a compile_error!() inside the non-linux version of kernel_check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR in #854 didn't strike me as particular elegant; and if we move to different OS's we might probably need different kernel checks as well. So this cleans up that routine.